The update password for Laravel passes verification, but does not update the entry

Question

Hi, I use Laravel and I use a couple of packages for user auth and roles that Zizaco Confide , and I want to update the user password first they must enter the current password there new password and confirm the password, and they must match. Now the check is performed, but the user password is not updated in the database. My code is below:

public function updatePassword($id) { $rules = array( 'now_password' => 'required', 'password' => 'min:5|confirmed|different:now_password', 'password_confirmation' => 'required_with:password|min:5' ); //password update. $now_password = Input::get('now_password'); $password = Input::get('password'); $passwordconf = Input::get('password_confirmation'); $validator = Validator::make(Input::only('now_password', 'password', 'password_confirmation'), $rules); if ($validator->fails()) { return Redirect::back()->withErrors($validator); } elseif (Hash::check($now_password, Auth::user()->password)) { $user = User::find($id); $user->password = Hash::make($password); $user->save(); return Redirect::back()->with('success', true)->with('message','User updated.'); } else { return Redirect::back()->withErrors('Password incorrect'); } } 

Any ideas why the user password is not updated with this code block

 $user = User::find($id); $user->password = Hash::make($password); $user->save(); 

User model

 <?php use Zizaco\Confide\ConfideUser; use Zizaco\Confide\ConfideUserInterface; use Zizaco\Entrust\HasRole; class User extends Eloquent implements ConfideUserInterface { use SoftDeletingTrait; use ConfideUser; use HasRole; protected $softDelete = true; public function favourites() { return $this->hasMany('Favourite'); } } 

Answer 1

To verify your password:

1.

  $now_password = Input::get('now_password'); $user = DB::table('users')->where('name', Auth::user()->name)->first(); if(Hash::check($now_password, $user->password)){ //Your update here } 

2.

 $now_password = Input::get('now_password'); if(Hash::check($now_password, Auth::user()->password)){ //Your update here } 

To check if they match, and if the new password is different from the old.

 $rules = array( 'now_password' => 'required|min:8', 'password' => 'required|min:8|confirmed|different:now_password', 'password_confirmation' => 'required|min:8', ); 

And edit your form (or enter your names):

 {{ Form::label('now_password', 'Old Password') }} {{ Form::password('now_password')}} {{ Form::label('password', 'New Password') }} {{ Form::password('password')}} {{ Form::label('password_confirmation', 'Confrim New Password') }} {{ Form::password('password_confirmation')}} 

Update

Good, therefore you do not want to edit only passwords.

Change your rules:

 $rules = array( 'now_password' => 'required|min:5', 'password' => 'min:5|confirmed|different:now_password', 'password_confirmation' => 'required_with:password|min:5' ); 

I think a current password should be required every time it is changed. Other imo inputs are not required because you do not know what data the user wants to edit.

You should also add something like:

 'username' => alpha_num|unique:users,username 

etc. (for more details see http://laravel.com/docs/4.2/validation#available-validation-rules )

If the validator passes, you should check which user wants to change (which inputs are not empty). Sort of:

 if(!empty(Input::get('firstname'))){ $user->firstname = Input::get('firstname'); } 

etc. with each entry.

Answer 2

Try the following:

 public function updatePassword($id) { $user = User::findOrFail($id); User::$rules['now_password'] = 'required'; // other rules here $validator = Validator::make($data = Input::all(), User::rules('update', $id)); if ($validator->fails()) { return Redirect::back()->withErrors($validator)->withInput(); } array_forget($data, 'password_confirmation'); array_forget($data, 'now_password'); $data['password'] = Hash::make($data['password']); $user->update($data); return Redirect::back()->with('success', true)->with('message','User updated.'); } 

Answer 3

remember that the name of the password confirmation field must be "password_confirmation" if you used the first method ... if you used a different name for the password confirmation field, you can use the second method.

 $this->validate($request, [ 'email' => 'required|unique:user|email|max:255', 'username' => 'required|max:20', 'password' => 'required|min:3|confirmed', 'password_confirmation' => 'required', 'gender' => 'required|in:m,f', ]); $this->validate($request, [ 'email' => 'required|unique:user|email|max:255', 'username' => 'required|max:20', 'password' => 'required|min:3', 'confirm_password' => 'same:password', 'gender' => 'required|in:m,f', ]); 

Answer 4

 public function change_password_post($id) { $rules = array( 'current' => 'required|string|min:8', 'new' => 'required|string|min:8', 'confirm' => 'required|same:new' ); $validator = Validator::make(Input::only('current', 'new', 'confirm'), $rules); if($validator->fails()) { return Redirect::back() ->withErrors($validator); } else { $users = User::where('id', '=', $id)->first(); if (Hash::check(Input::get('current'), $users->password)) { if(Input::get('new') == Input::get('confirm')) { $users->password =Hash::make(Input::get('new')); $users->save(); $msg = array('msg' => 'Password changed Successfully'); return Redirect::back() ->withErrors($msg); } else { $msg = array('msg' => 'New password and Confirm password did not match'); return Redirect::back() ->withErrors($msg); } } else { $msg = array('msg' => 'Current password is incorrect'); return Redirect::back() ->withErrors($msg); } } }