This thread generalizes the process:
Project Configuration:
- Predefined condition: "
Require Work Item Approval
" for operation " Deliver (client)
" for the role " Everyone
". - In "
Required approvals
" for the type " Review
" at least one of the roles " Everyone
" (or " Team Member
") is set.
" User may overrule
" can also be checked if not for the entire code delivery a verification process may be required.
Scenario:
There are three developers β D1
, D2
and D3
β all using the ETC Rcl client.
- Does
D1
change the code for files f1
and f2
in its local workspace and save them. f1 and f2 are displayed as unresolved in the pending change view. D1
checks f1 and f2 for the new change set " CS
".
Right-click on β CS
β and select the β Submit for Review
β menu item and map to the WI (existing or new) and select approvers:D2
as a statement for the f1
review (the topic field is used to tell you what to view) andD3
as confirmation for review f2
.
- The approval / verification process will be pending.
D2
and D3
get an idea of ββthe verification task assigned to them through the request - "Awaiting confirmation for me."D2
opens WI and in the "Links" section, double-clicks f1
in the changeset and looks at diff in the changes explorer.
Overview.
Optionally adds a comment for D1
in the WI
discussion field.
Changes the status of the Review
approval from pending
to approved
.
D3
follows the same process as D2
, but rejects because changing the code f3
unacceptable. Changes the state of the Review
approval from pending
to rejected
.D1
receives a comment for viewing via email / channel - because D1
is the owner and subscriber of WI.D1
corrects the code in f2
based on D3
and checks it for the same set of changes.D1
adds D3
again for a new review approval in the same WI.D3
receives the assignment of the review task assigned to it through the request - " Pending approvals for me
".D3
opens the WI in the Links section, double-clicks f2
in the changeset and looks at diff in the changes explorer.
Overview.
Optionally adds a comment for D1
in the WI discussion field.
Changes the status of a review approval from pending
to approved
.D1
receives a comment for viewing via email / channel - because D1
is the owner and subscriber of WI.D1
provides a set of changes (or calls the " Complete
" action on the set of changes) because all approvals in the WI are in an approved state.- The full history of the code review process (rejected, approved) is located on the "
Approvals
" tab.
source share