OutOfMemoryError in implementation of quick sort in Java

I am trying to implement the Quicksort algorithm, I read how to do it with pseudo-code, and since I am learning Java (because I already did quicksort several months ago in C ++), I want to implicate it in such a language, but I get stackoverflow problem or a lot of space when I try to run it, can you check my code ?: D

    public static int[] quicksort(int arreglo[]){
    int size=arreglo.length;
    int pivote=arreglo[size/2];
    int menor[] = new int[size+2]; //If I leave the +2 I get stack overflow
    int mayor[] = new int[size+2]; //If I delete them I get heap space problems
    int j=0,k=0;
    if(size>2){
        for(int i=0;i<size;i++){
            if(arreglo[i]<=pivote){
                menor[j]=arreglo[i];
                j++;
            }
            else{
                mayor[k]=arreglo[i];
                k++;
            }
        }
        if(menor.length>=1&&mayor.length>=1)
            return concatena(Ordena.quicksort(menor),Ordena.quicksort(mayor),j,k);
        else
            if(menor.length>mayor.length)
                return menor;
            else
                return mayor;
    }
    else
        return arreglo;
}

public static int[] concatena(int menor[],int mayor[],int limite1,int limite2){
    int completo[] = new int[limite1+limite2];
    System.arraycopy(menor,0,completo,0,limite1);
    System.arraycopy(mayor,0,completo,limite1,limite2);
    return completo;
}

Thanks for all your comments and answers, I made the proposed changes, I will make the exact exception:

"main" java.lang.OutOfMemoryError: Java heap space      Ordena.quicksort(Ordena.java:6)      Ordena.quicksort(Ordena.java21)      Ordena.quicksort(Ordena.java21)      Ordena.quicksort(Ordena.java21)      Ordena.quicksort(Ordena.java21)      Ordena.quicksort(Ordena.java21)      Ordena.quicksort(Ordena.java21)      Ordena.quicksort(Ordena.java21)      Ordena.quicksort(Ordena.java21)      Ordena.quicksort(Ordena.java21)      Ordena.quicksort(Ordena.java21)      Ordena.quicksort(Ordena.java21)      Ordena.quicksort(Ordena.java21)      Ordena.quicksort(Ordena.java21)      Ordena.quicksort(Ordena.java21)      Ordena.quicksort(Ordena.java21)      Ordena.quicksort(Ordena.java21)      Ordena.quicksort(Ordena.java21)      Ordena.quicksort(Ordena.java21)      Ordena.quicksort(Ordena.java21)      Ordena.quicksort(Ordena.java21)      Ordena.quicksort(Ordena.java21)      Ordena.quicksort(Ordena.java21)      Ordena.quicksort(Ordena.java21)      Ordena.quicksort(Ordena.java21)      Ordena.quicksort(Ordena.java21)      Ordena.quicksort(Ordena.java21)      Ordena.quicksort(Ordena.java21)      Ordena.quicksort(Ordena.java21)      Ordena.quicksort(Ordena.java21)      Ordena.quicksort(Ordena.java21)      Ordena.quicksort(Ordena.java21)

( , , ):

    public static int[] quicksort(int array[]){
    int size=array.length;
    int pivot=array[size/2];
    int less[] = new int[size+2];
    int greater[] = new int[size+2];
    int j=0,k=0;
    if(size>2){
        for(int i=0;i<size;i++){
            if(array[i]<=pivot){
                less[j]=array[i];
                j++;
            }
            else{
                greater[k]=array[i];
                k++;
            }
        }
        less[j]=pivot;
        if(j>=1&&j>=1)
            return concatenate(Ordena.quicksort(less),Ordena.quicksort(greater),j,k);
        else
            if(j>k)
                return less;
            else
                return greater;
    }
    else
        return array;
}

public static int[] concatenate(int less[],int greater[],int limit1,int limit2){
    int complete[] = new int[limit1+limit2];
    System.arraycopy(less,0,complete,0,limit1);
    System.arraycopy(greater,0,complete,limit1,limit2);
    return complete;
}
+3
1

:

if(menor.length>=1&&mayor.length>=1)

if(j>=1&&k>=1)

? , , , , , . Quicksort , . , , .

, , . ? , . -,

if(menor.length>mayor.length)

if(j>k)

. , , . , quicksort, . , , , , quicksort ( ) . , .

.

+3

Source: https://habr.com/ru/post/1776591/


All Articles