How do I do Ajax with Django now: looking for tips / comments

Question

I would like to share with you how I am doing my Ajax stuff with Django at the moment. I would like to receive your advice / comments to make sure that I am doing it right.

Of course, I would simplify the code just to show the process.

Here is my template code:

<!-- I store the full url to access object details so I can use url feature.
If I just store the pk, I would have to hardcode the url to fetch the object
detail later. Isn't it? -->
<ul>
{% for item in items %}
    <li url="{% url project.item.views.details item.pk %}">{{ item.name }}</li>
{% endfor %}
<ul>

<div id="details"></div>


<script> 
$("li").click(function(elmt){
    // I just reuse the url attribute from the element clicked
    var url = $(elmt.currentTarget).attr('url');
    $.getJSON(url, function(data) {
        if (data.success) {
            $("#details").html(data.html);
        } else {
            $("#details").html("Something went wrong");
        }
    });
});
</script>

Here is the code that I use in my view:

def details(request, item_id):
    item = Items.objects.get(pk=item_id)
    # Just render a view with the details, and return the view
    html = render_to_string("items/_details.html", {'item': item})
    return HttResponse(simplejson.dumps({'success': True, 'html': html}), mimetype="application/json")

What do you think of my way of doing this?

Thank you in advance for your help!

Answer 1

Nothing wrong with Django code, but you might want it to work for clients without javascript, and use valid HTML:

<ul>
{% for item in items %}
    <li><a href="{{ item.get_absolute_url }}">{{ item.name }}</a></li>
{% endfor %}
<ul>

$("a").click(function(){
    // I just reuse the url attribute from the element clicked
    // li does not have an url attribute
    var url = $(this).attr('href');
    $.getJSON(url, function(data) {
        if (data.success) {
            $("#details").html(data.html);
        } else {
            $("#details").html("Something went wrong");
        }
    });
    return false;
});

def details(request, item_id):
    item = Items.objects.get(pk=item_id)
    # Just render a view with the details, and return the view
    if request.is_ajax():
        html = render_to_string("items/_details.html", {'item': item})
        return HttResponse(simplejson.dumps({'success': True, 'html': html}), mimetype="application/json")
    else:
        #non ajax request rendering complete html
        return render_to_response("items/detail.html", {'item': item})

Answer 2

-, Django, , .

, -, , .