It is better to write if the condition

Question

Is there a better way to write this condition down?

if (self.expense.nil? && self.income.nil?) || (!self.expense.nil? && !self.income.nil?)
  puts "test"
end

Answer 1

You check if the expressions are true or false. Try the following:

if (self.expense.nil? == self.income.nil?)

You don't care if they are true or false, they just are the same.

Answer 2

Despite the logic, since you use if to check for zero, you can shorten the code as follows:

if ((expense && income) || (!expense && !income))
  puts "test"
end

Correct me if I am wrong.

Answer 3

You can use Demorgan law for the second half of the if condition

therefore (!self.expense.nil? && !self.income.nil?)it becomes!(self.expense.nil? || self.income.nil?)