C #: How to solve this cyclic dependency?

Question

I have a circular dependency in my code, and I'm not sure how to resolve it.

I am developing a game. NPCs have three components that are responsible for thinking, perception, and action. These components need access to the NPC controller to access its model, but the controller needs these components to do something. Thus, both perceive each other as arguments in their constructors.

ISenseNPC sense = new DefaultSenseNPC(controller, worldQueryEngine);
IThinkNPC think = new DefaultThinkNPC(sense);
IActNPC act = new DefaultActNPC(combatEngine, sense, controller);
controller = new ControllerNPC(act, think);

(In the example above, the parameter is a bit simplified.)

Without actand think, controllernothing can be done, so I do not want to allow its initialization without them. Otherwise, this is also true. What should I do?

ControllerNPCusing thinkand actto update their state in the world:

public class ControllerNPC {
   // ...
           public override void Update(long tick)
        {
            // ...
            act.UpdateFromBehavior(CurrentBehavior, tick);

            CurrentBehavior = think.TransitionState(CurrentBehavior, tick);
        }
   // ...

}

DefaultSenseNPC controller, , -:

 public class DefaultSenseNPC {
       // ...
            public bool IsCollidingWithTarget()
            {
                return worldQuery.IsColliding(controller, model.Target);
            }
       // ...
    }

Answer 1

. .

, :

http://www.mellekoning.nl/index.php/2010/03/11/project-references-in-ddd/

Answer 2

, null , set :

ISenseNPC sense = new DefaultSenseNPC(worldQueryEngine);
IThinkNPC think = new DefaultThinkNPC();
IActNPC act = new DefaultActNPC(combatEngine);
controller = new ControllerNPC();

sense.setController(controller);
think.setSense(sense);
act.setSense(sense);
act.setController(controller);
controller.setAct(act);
controller.setThink(think);

// And now the objects are ready to use.

Answer 3

?

Answer 4

, : , , ...

, - "" , ( ), - "", "", "".

3 : "ThinkModel", "ActModel", "SenseModel". .

(, , ) , "DoAction", "ThinkingAbout", "FeelingSomething" .

, "ActionOccured", "ThinkingOccured", "SenseingOccured" ( "FeeledSomething" ). :

• - ;
• ;
• .

, , . . . :

IThinkModel modelThinkg = new ThinkModel();
IActModel modelAct = new ActModel();
ISenseModel modelSense = new SenseModel();

IController controller = new Controller(modelThinkg, modelAct, modelSense);

ISenseNPC sense = new DefaultSenseNPC(controller);
IThinkNPC think = new DefaultThinkNPC(sense);
IActNPC act = new DefaultActNPC(combatEngine, sense, controller);

:

class DefaultSenseNPC
{
    DefaultSenseNPC(IController controller)
    {
        _controller = controller;
        _contoller.ThinkingAbout += ContollerReceivedNewThinking;
    }

    private ContollerReceivedNewThinking(IModelThinking modelNewThink)
    {
        _modelNewThink = modelNewThink;// store it for further calculations.
    }
}

, .

P.S. "" MVP-, .