MySQL upgrade problem

Question

$result=mysql_query(" UPDATE xxxxxx_users SET User_Password='$Password' WHERE FstName='$First' AND LstName='$Last'",$db)  or die ("Password update successful!");
echo "Update failed, unknown user";

This correctly updates db when the first and last name match, and db does not affect when they do not. My only problem is that I always show an “Unsuccessful update” error message, unknown. What have I done wrong? Thank.

Answer 1

The mysql_query function returns true if the SQL query completes successfully:

For other types of SQL, INSERT, UPDATE, DELETE, DROP, etc. statements mysql_query () returns TRUE on success or FALSE on error.

, . mysql_affected_rows:

$result=mysql_query(" UPDATE xxxxxx_users SET User_Password='$Password' WHERE FstName='$First' AND LstName='$Last'",$db)
if (mysql_affected_rows() > 0)
  die ("Password update successful!");
else
  echo "Update failed, unknown user";

Answer 2

, ...

$result=mysql_query(" UPDATE xxxxxx_users SET User_Password='$Password' WHERE FstName='$First' AND LstName='$Last'",$db)
     or die ("Update failed, unknown user"); 

echo "Password update successful!";

Answer 3

If the first part (mysql_query) is true, there is no need to evaluate the second or part (die). You can use and instead.

And please read about SQL Injections.

Suggestion for your coding style:

Something like that:

if ($result)
   ...success
else 
   ...fail

is more readable.