How to encapsulate a stored procedure call

Question

I have a DAO class that I use to perform database operations. I have many stored procedures that I call from different methods / functions. In each function / Method, I write one line to add parameter values ​​for SP. Is there any way to encapsulate this so that all functions / Methods can call this encapsulated functionality to pass parameters to another stored procedure. I am sure that many of you have worked on something similar to this. Basically, I try to avoid redundant statements to add parameters to the parameter set.

(I am using C # 3.5)

Answer 1

Something like this might be:

public static IDataReader GetDataReader(string connectionStringKey, string storedProcedure, Dictionary<string, object> parameters) {
    try {
        SqlCommand command = GetCommandWithConnection(connectionStringKey);
        command.CommandText = storedProcedure;
        command.CommandType = CommandType.StoredProcedure;
        foreach (var parameter in parameters ?? new Dictionary<string, object>())
            command.Parameters.AddWithValue(parameter.Key, parameter.Value);
        command.Connection.Open();
        return command.ExecuteReader();
    }
    catch (Exception e) {
        Log.Error(string.Format("Error in GetDataReader, executing sp: {0}", storedProcedure), e);
        throw;
    }     
}
private static SqlCommand GetCommandWithConnection(string connectionStringKey) {
    return new SqlConnection(GetConnectionString(connectionStringKey)).CreateCommand();
}
private static string GetConnectionString(string connectionStringKey) {
    return ConfigurationManager.ConnectionStrings[connectionStringKey].ToString();
}

: , , , dal:

public static T GetScalar<T>(string connectionStringKey, string storedProcedure, Parameters parameters) {
    try {
        List<Parameter> outs = null;
        SqlCommand command = GetCommandWithConnection(connectionStringKey);
        command.CommandText = storedProcedure;
        command.CommandType = CommandType.StoredProcedure;
        if (parameters != null) {
            outs = parameters.FindAll(p => p.Direction != ParameterDirection.Input);
            parameters.ForEach(p => command.Parameters.AddWithValue(p.Key, p.Value).Direction = p.Direction);
        }
        command.Connection.Open();
        object o = command.ExecuteScalar();
        T result = (o != null) ? (T)o : default(T);
        if (outs != null && outs.Count > 0) {
            foreach (Parameter parameter in outs) {
                SqlParameter sqlParameter = command.Parameters[parameter.Key];
                parameters[parameter.Key] = (sqlParameter.Value == DBNull.Value) ? null : sqlParameter.Value;
            }
        }
        command.Connection.Close();
        if (o == null && (typeof(T) == typeof(int)) && parameters != null && parameters.ContainsKey("RowCount"))
            result = (T)parameters["RowCount"];
        return result;
    }
    catch (Exception e) {
        Log.Error(String.Format("Error in GetScalar<{0}>, executing sp: {1}", typeof(T).Name, storedProcedure), e);
        throw;
    }
}

:

public class Parameter{
    public string Key { get; private set; }
    public object Value { get; protected internal set; }
    public ParameterDirection Direction { get; protected internal set; }
    public Parameter(string key, object value) : this(key, value, ParameterDirection.Input) { }
    public Parameter(string key, object value, ParameterDirection direction){
        Key = key;
        Value = value;
        Direction = direction;
    }
}
public class Parameters : List<Parameter>{
    public Parameters() { }
    public Parameters(object o){
        Populate(o);
    }
    public void Add(string key, object value){
        if (ContainsKey(key))
            throw new Exception("Parameter with the specified key already exists.");
        Add(new Parameter(key, value));
    }
    public void Add(string key, object value, ParameterDirection direction){
        if (ContainsKey(key))
            throw new Exception("Parameter with the specified key already exists.");
        Add(new Parameter(key, value, direction));
    }
    public bool ContainsKey(string key){
        return (Find(p => p.Key == key) != null);
    }
    protected internal int GetIndex(string key){
        int? index = null;
        for (int i = 0; i < Count; i++){
            if (this[i].Key == key){
                index = i;
                break;
            }
        }
        if (index == null)
            throw new IndexOutOfRangeException("Parameter with the specified key does not exist.");
        return (int)index;
    }
    public object this[string key]{
        get { return this[GetIndex(key)].Value; }
        set { this[GetIndex(key)].Value = value; }
    }
    private void Populate<T>(T obj){
        foreach (KeyValuePair<string, object> pair in new ObjectProperties(obj, BindingFlags.Public | BindingFlags.Instance))
            Add(pair.Key, pair.Value);
    }
}