Long lines of code and readability

Question

This is great C # code and works great with the right URL. But everything is simply done on the same line, reducing code readability.

Here is the code:

         return new StreamReader(WebRequest.Create(urlName).GetResponse().GetResponseStream()).ReadToEnd();

I'm just curious about the opinions of other developers regarding such a short way to write code.

Answer 1

Point it to a well-named method and possibly break it down so that one statute spans a couple of lines. I would also use WebClient:

return new WebClient().DownloadString(urlName);

Answer 2

No, this is not a great C # code. You must dispose of StreamReader, so at least there is an instruction using:

using (StreamReader reader = new StreamReader(WebRequest.Create(urlName).GetResponse().GetResponseStream()) {
   return reader.ReadToEnd();
}

, , .

. . :

if (i <= 4) i = 4 - i;

if , if :

if (i <= 4) {
   i = 4 - i;
}

, , , , .

Answer 3

... YUCK.

, , , .

( , ++) , , , , . #, , .

Answer 4

In addition to the readability issue, you should use any IDisposble object that you use.

Answer 5

One statement! = One line, you can improve readability by improving the formatting of your code. Of course, you should not assume that other people use high-resolution monitors.