Is this setter "evil"

Question

There is a lot of talk about what getters and setters are “evil” and what is not.

My question is: the next evil setter? (the rest of the class is omitted for brevity)

int balance

public void deposit(int amount)  
{  
    this.balance += amount;  
}

This class emulates ATM. In the UK there are several ATMs that allow you to make deposits and also withdraw, so this object needs to change its state (balance). Is this setter evil?

Answer 1

Except for the fact that there is no handling of exceptional conditions, it looks like an absolutely good OO method - he called what he does and does what you expect.

Answer 2

, , , .

, , "" . . (IMO) " " :

account.SetBalance(account.GetBalance() + depositAmount)

; . , getter/setter.

Answer 3

? , "". , . Setters Getters (). , :

, , , .

Answer 4

, , . , , , .

"" :

int balance

private void setBalance(int amount)
{
    this.balance = amount;
}

public void deposit(int amount)  
{  
    setBalance(this.balance + amount);  
}

ATM , . , .

Answer 5

, .

public void deposit(int new_balance)
{
    this.balance = new_balance;
}

, , , , , . .

Answer 6

, , ..... , .

, , , , , , .

Answer 7

; , (). , , . , . , , , , .

Answer 8

, , , . , , , .

Answer 9

IMO, "" .

( , "" )

, Account "balance" , , "modifyBalance", .

ATM "modifyBalance" Account .

Answer 10

, , .

, , , .

, , , , , , .

Answer 11

. ( -, - ).

Setter - , . - , . .

If you have a strange data structure, you may not have a “balance” variable. Regardless of the data structure, you will have to have a “deposit” function. There is part of the difference.

Answer 12

that is not a setter, its normal method

even if it was a setter, it is not evil

This is an evil setter

int _balance = 0;  
public int Balance()  
{  
    get { return _balance; }  
    set { }    //now that evil!  
}