When can I use the GoTo instruction in VB.Net?

Question

I have a process that should create a bunch of records in the database and drop everything if something goes wrong. I want to do the following:

Public Structure Result
    Public Success as Boolean
    Public Message as String
End Structure

Private _Repository as IEntityRepository

Public Function SaveOrganization( _
    ByVal organization As rv_o_Organization) As Result
    Dim result = Result.Empty

    _Repository.Connection.Open()
    _Repository.Transaction = _Repository.Connection.BeginTransaction()

    ''//Performs validation then saves it to the database
    ''// using the current transaction
    result = SaveMasterOrganization(organization.MasterOrganization)
    If (Not result.Success) Then
        GoTo somethingBadHappenedButNotAnException
    End If

    ''//Performs validation then saves it to the database
    ''//using the current transaction
    result = SaveOrganziation(dbOrg, organization)
    If (Not result.Success) Then GoTo somethingBadHappenedButNotAnException

somethingBadHappenedButNotAnException:
    _Repository.Transaction.Commit()
    _Repository.Connection.Close()
    Return result
End Sub

Is it ok to use a GoTo instruction or just a bad design? Is there a more elegant solution? I hope this sample can get a point in

Answer 1

If you need to ask, do not do this.

For your specific code, you can do it like this:

Public Function SaveOrganization(ByVal organization As rv_o_Organization) As Result
    Dim result As Result = Result.Empty

    _Repository.Connection.Open()
    _Repository.Transaction = _Repository.Connection.BeginTransaction()

    'Performs validation then saves it to the database 
    'using the current transaction
    result = SaveMasterOrganization(organization.MasterOrganization)

    'Performs validation then saves it to the database 
    'using the current transaction
    If result.Success Then result = SaveOrganziation(dbOrg, organization)

    _Repository.Transaction.Commit()
    _Repository.Connection.Close()
    Return result
End Sub

Answer 2

Really bad design. Yes.

Answer 3

Goto , . , goto - , .

.

Answer 4

, , , , .

Using, . , , IDisposable ( , ), Dispose. (, ).

, TransactionScope, , , .

Answer 5

, goto, - .

, , - .

try... , , (, #)

void DoStuff()
{
    Connection connection = new Connection();
    try
    {
        connection.Open()
        if( SomethingBadHappened )
            return;
    }
    finally
    {
        connection.Close();
    }    
}

Answer 6

. , GOTO, . , , vb On Error Goto.

Answer 7

goto , . , .

. , , REAL, .

Answer 8

Gotos - . / goto ( !) while ( ) gotos, . - - ( - )

, . , . , , .

, . , , , - , - , , , .

, , goto (ps. psuedocode -):

dbMethod() {
    start transaction
    if(doWriteWorks())
        end Transaction success
    else
        rollback transaction
}
doWriteWorks() {
    validate crap
    try Write crap
    if Fail
        return false
    validate other crap
    try Write other crap
    if Fail
        return false
    return true
}

, VB, VB 3 ( , MS ), , - -, . , MS , ...

Answer 9

goto , , Try Catch, , "Retry?, Cancel", , StartMyTask: .

.

For each Items in MyList

 If VaidationCheck1(Item) = false then goto SkipLine
 If ValidationCheck(Item) = false then goto skipline

 'Do some logic here, that can be avoided by skipping it to get better performance.
 'I use then like short circuit operands, why evaluate more than you actually have to?

 SkipLine:
Next

, , , , -.

Answer 10

, goto, . , "",

Answer 11

, , , . , 20 , Goto , .

Answer 12

catch try, , , . , GOTO.

, GOTO , , , , , . , , BASIC.

Answer 13

, , . .

, , GOTO select, #, VB.

Answer 14

go . , , 6 " ".

go to , , . , try... catch , , go tos.

, , : -)

go - , , . clean_up: .

Answer 15

Eh, VBscript/ASP . ASP , .

in.net? , !

Answer 16

, . GOTO - - .

, , - . GOTO , .

, , , , .NET.