All geek questions in one place

CI Code Reviews

What things are you looking for in a code review when using continuous integration? It seems that in the literature, many code reviews mention things like coding style, spelling errors, resource use, error handling, etc. (Maybe not in that order :-) However, tools like FxCop and StyleCop, are trivial tasks.

I would think that as many checks as possible can be inserted into the CI to save time and make sure that these checks are performed sequentially. If you take this approach, it seems that the main things to look for in a review are things like poor design, improper use of the existing code structure, subtle defects that might be missed in tests, etc.

How do everyone else review using CI? What other things are you looking for in a review?

+3
source share
5 answers
  • Security concerns
  • Performance issues
  • Usability for GUIs
  • Scability
  • Good comment

To a large extent, regardless of what cannot be automatically tested by the machine (with the possible exception of performance / security problems, but it is much easier for people to detect.)

+3
source

- , . . , . , FxCop ReSharper, .

+1

, : . , A B , . / 100% Spring. , .

( ), CI. " " .

: , . , .

+1

- , . . , changeX(), X , getFoo(), foo, 7 .

0

. , , , . , , , , ( , ) , . , , . , .

". , , . , FxCop . , Microsoft Source Analysis (aka StyleCop), . TDD-, , -. NDepend , , , . , . - " ? " , FxCop, StyleCop NDepend , , . , - , , , . " " - , , , - , -, . - " ". - TeamReview - New Business Value from Code Review

0
source

Source: https://habr.com/ru/post/1697308/

More articles:


All Articles