On Click does not update function output

Question

On Click does not update function output

$('.btn').on("click", function() {
  var text = $(this).text();
  $(this).text(text === 'Celsius' ? 'Fahrenheit' : 'Celsius');
  changeUnits();
});

function changeUnits(Temp, c) {
  if ($('.btn').text() === 'Celsius')   
    return Math.round((Temp - 273.15)*10)/10 + " &degC";
  else
  return Math.round(((Temp* (9/5)) - 459.67)*10)/10 + " &degF";
}

I am trying to use a button on a click to change the tempo display, but it does not seem to work. The function continues to see Celsius, no matter what. I also tried $ (this) .html. The button text actually changes, just the function is not updated. I tried to launch the unit function inside the button by pressing the button, even if it is not yet updated.

What I do not understand about this onclick event and how to make it work.

JS Code:

    var apiKey = "get your own key from http://openweathermap.org";

  function changeUnits(Temp, c) {
  if ($('.btn').text() === 'Celsius')   
    return Math.round((Temp - 273.15)*10)/10 + " &degC";
  else
  return Math.round(((Temp* (9/5)) - 459.67)*10)/10 + " &degF";
}

$('.btn').on("click", function() {
  var text = $(this).text();
  $(this).text(text === 'Celsius' ? 'Fahrenheit' : 'Celsius');
  changeUnits();
});

$(function() {
  var loc;
  //api call to get lat and long
  $.getJSON('http://ipinfo.io', function(data) {
    loc = data.loc.split(",");

    //weather API call
    $.getJSON('http://api.openweathermap.org/data/2.5/weather?lat=' +
      loc[0] + '&lon=' + loc[1] + '&appid=' + apiKey,
      function(weather) {
        var currentLocation = weather.name;
        var currentConditions = weather.weather[0].description;
        var currentTemp = changeUnits(weather.main.temp);
        var high = changeUnits(weather.main.temp_max);
        var low = changeUnits(weather.main.temp_min);
        var currentWind = weather.wind.speed;
        var currentWdir = weather.wind.deg;
        var sunRise = weather.sys.sunrise;
        var sunSet = weather.sys.sunset;
        var icon = weather.weather[0].icon;
        //set HTML elements for weather info
        $('#currentLocation').append(currentLocation);
        $('#currentTemp').html(currentTemp);
        $('#high-low').html('<span id="high">High: ' + high + '</span><br>' 
                            + '<span id="low">Low: ' + low + '</span>');
        $('#currentConditions').html(currentConditions);

        var iconSrc = "http://openweathermap.org./img/w/" + icon + ".png";
        $('#currentConditions').prepend('Outside the current conditions are <br><img id="weatherImg"src="' + iconSrc + '"><br>');
      });
  });
});

HTML:

<html>
<head>
    <meta name="keywords" content="HTML, CSS, XML, XHTML, JavaScript,width=device-width,initial-scale=1">
    <title></title>
</head>
<body>
  <div id="header">
    <div class="left"><h1 id="currentLocation">Your Current Location is  </h1></div>
    <div class="navbar"></div>
    <div class="right"><a href="https://github.com/Maverick494"><i class="fa fa-github bigger_icon"></i></a></div>
  </div>
  <div id="container">
    <h2 class="text-center content-title" id="currentTemp"></h2>
    <div class="content-body text-center">
      <p id="high-low"></p>
      <button data-text-swap="Fahrenheit" id="unitButton" type="button" class="btn btn-success">Celsius</button>
      <p id="currentConditions"></p>
    </div>
  </div>
</body>
</html>

I made all the changes that I can think of. console.log (el.text ()) in onclick clearly shows the text change; but the changeUnits function will never take it in the if statement when I run the function again during onclick.

+4

javascript jquery

Shenanigator Mar 03 '17 at 17:12

5

, - .btn , .

$('.btn').on("click", function() {
  var text = function(f, c) {  // where are you getting your f and c parameters?
        console.log(f); // should be undefined
        console.log(c); // should be undefined
        return c === 'Celsius' ? 'Fahrenheit' : 'Celsius';
      }();
  console.log(text); // should be 'Celsius'
  $(this).text(text);   // changed from })  to }())
});


function changeUnits(Temp, c) {
  if ($('.btn').text() === 'Celsius')   //  change html() to text() as well
    return Math.round(Temp - 273.15) + " &degC";
  else
  return Math.round((Temp* (9/5)) - 459.67) + " &degF";
}

, ,

<input id='thisID'>
// then call it in javascript
$("#thisID")

$('.btn').on("click", function() {
  var text = $(this).text();
  $(this).text(text === 'Celsius' ? 'Fahrenheit' : 'Celsius');
});

0

Jackstine 03 . '17 17:37

, html() text(). , html, :

$('.btn').on("click", function() {
  $(this).text(function(f, c) {
    return c === 'Celsius' ? 'Fahrenheit' : 'Celsius';
  });
});

function changeUnits(Temp, c) {
  if ($('.btn').text() === 'Celsius'){
    return Math.round(Temp - 273.15) + " &degC";
  }else{
    return Math.round((Temp* (9/5)) - 459.67) + " &degF";
  }
}

0

Meules 03 . '17 17:45

, . , API . , .

, OpenWeatherMap. - , . ajax, .

:

var currentTemp;
var high;
var low;

$(function() {
  var loc;
  //api call to get lat and long
  $.getJSON('http://ipinfo.io', function(data) {
    loc = data.loc.split(",");

    //weather API call
    $.getJSON('http://api.openweathermap.org/data/2.5/weather?lat=' +
      loc[0] + '&lon=' + loc[1] + '&appid=' + apiKey,
      function(weather) {
        var currentLocation = weather.name;
        var currentConditions = weather.weather[0].description;
        currentTemp = weather.main.temp;
        high = weather.main.temp_max;
        low = weather.main.temp_min;
        var currentWind = weather.wind.speed;
        var currentWdir = weather.wind.deg;
        var sunRise = weather.sys.sunrise;
        var sunSet = weather.sys.sunset;
        var icon = weather.weather[0].icon;
        //set HTML elements for weather info
        $('#currentLocation').append(currentLocation);
        updateDisplay();
        $('#currentConditions').html(currentConditions);

        var iconSrc = "http://openweathermap.org./img/w/" + icon + ".png";
        $('#currentConditions').prepend('Outside the current conditions are <br><img id="weatherImg"src="' + iconSrc + '"><br>');
      });
  });
});

function changeUnits(Temp) {
  if ($('.btn').text() === 'Celsius')   
    return Math.round((Temp - 273.15)*10)/10 + " &degC";
  else
  return Math.round(((Temp* (9/5)) - 459.67)*10)/10 + " &degF";
}

$('.btn').on("click", function() {
  var text = $(this).text();
  $(this).text(text === 'Celsius' ? 'Fahrenheit' : 'Celsius');
  updateDisplay();
});


function updateDisplay(){
      $('#currentTemp').html(changeUnits(currentTemp));
      $('#high-low').html('<span id="high">High: ' + changeUnits(high) + '</span><br>' 
                                    + '<span id="low">Low: ' + changeUnits(low) + '</span>');
}

updateDisplay(), . , . , .

0

Medard Mar 08 '17 at 11:24

source share

Your script will probably be loaded before the DOM is ready.

What you want to do here is one of several options: 1. Load the JS script tag at the end of the body. 2. Wrap the $ ('. Btn') function. On (...) with the document.on ('ready') event, so this code will only run when the DOM is ready.

0

Daniel Mar 13 '17 at 14:30

source share

Shenanigator · Accepted Answer · 2017-03-10T01:38:39+0000

JS:

var apiKey="get an openweathermap APIKey";    
var loc;
var lat;
var long;

var temp;
var high;
var low;
var icon;
//var wind;
//var windDir;
//var windSpd;

//api call to get lat and long
$.getJSON('http://ipinfo.io', function(data) {
  loc = data.loc.split(",");
  lat = parseFloat(loc[0]);
  long = parseFloat(loc[1]);
  getWeather(lat, long);
  initGmaps(lat, long);
});

//api call to use lat and long to generate a map
window.addEventListener('load', function() {

  var script = document.createElement('script');
  script.type = 'text/javascript';
  script.src = '?key=AIzaSyDKgEmSnYmFmbhQVGY8K6NXxV5ym2yZXdc&callback=initMap';
  document.body.appendChild(script);
});

function initGmaps(lat, long) {
 var map = new GMaps({
    div: '#map',
    lat: lat,
    lng: long,
    zoom: 14,
    disableDefaultUI: true,
    mapTypeId: "satellite",
  });
map.addMarker({
  lat: lat,
  lng: long
});
}

//using weather to get data and plug it into our page
function getWeather(lat, long) {
  var api = 'http://api.openweathermap.org/data/2.5/weather?lat=' +
    lat + '&lon=' + long + '&appid=' + apiKey;

  $.ajax({
    url: api,
    dataType: 'json',
    success: function(data) {
      temp = {
        f: Math.round(((data.main.temp * 9 / 5) - 459.67) * 100) / 100 + " °F",
        c: Math.round(((data.main.temp - 273.15)) * 100) / 100 + " °C"
      };
      high = {
        f: Math.round(((data.main.temp_max * 9 / 5) - 459.67) * 100) / 100 + " °F",
        c: Math.round(((data.main.temp_max - 273.15)) * 100) / 100 + " °C"
      };
      low = {
        f: Math.round(((data.main.temp_min * 9 / 5) - 459.67) * 100) / 100 + " °F",
        c: Math.round(((data.main.temp_max - 273.15)) * 100) / 100 + " °C"
      };

      windSpd = {
        f: Math.round((data.wind.speed * 2.23694)*10)/10 + " MPH",
        c: Math.round((data.wind.speed)*10)/10 + " M/S"
      };

      var windArr = ["N","NNE","NE","ENE","E","ESE", "SE", "SSE","S","SSW","SW","WSW","W","WNW","NW","NNW"];

      var windDir = windArr[Math.floor(((data.wind.deg/22.5)+.5))]; 

      $('#currentLocation').append(data.name);
      $('#high').append(" " + high.f);
      $('#low').append(" " + low.f);
      $('#currentTemp').html(temp.f);
      $('#weatherDesc').html(data.weather[0].description);
      $('#windDir').html(windDir);
      $('#windDir').append('<span id="windSpd">' + windSpd.f + '</span>');            


      icon = data.weather[0].icon;
      var iconSrc = "http://openweathermap.org./img/w/" + icon + ".png";
      $('#currentConditions').html('<img id="weatherImg" src="' + iconSrc + '"><br>');
    }
  });
}

$('#currentTemp').on('click', function() {
  var current = $(this).data('nexttemp');
  $('#currentTemp').text(temp[current]);
  $('#high').html(high[current]);
  $('#low').html(low[current]);
  $('#windSpd').html(windSpd[current]);

  if (current == 'c') {
    $(this).data('nexttemp', 'f');
    return;
  }
  $(this).data('nexttemp', 'c');
});

HTML:

<html>
<head>
    <meta name="keywords" content="HTML, CSS, XML, XHTML, JavaScript,width=device-width,initial-scale=1">
    <title></title>
</head>
<body>
  <div id="header">
    <div class="left"></div>
    <div class="navbar"><h4>Free Code Camp Weather App</h4></div>
    <div class="right"><a href="https://github.com/Maverick494"><i class="fa fa-github bigger_icon"></i></a></div>
  </div>
    <div id="container">
      <div class="col-lg-4" id="map"></div>
      <div class="col-lg-4">
      <h1 id="currentLocation">Your Current Location is </h1>
      </div>
      <h2 class="center-text content-title" id="currentTemp"></h2>
      <h3 id="caption">Click temperature to change Units</h3>
      <div class="center-text">
      <p class="oneLine" id="labels">High: <span id="high"></span></p>
      <p class="oneLine" id="labels">Low:  <span id="low"></span></p>
      </div>
      <p class="center-text" id="currentConditions"></p>
      <p class="center-text" id="weatherDesc"></p>
      <div class="windCompass col-lg-4">
        <div class="compass">
          <div class="direction">
            <p id="windDir"></p>
          </div>
          <div class="arrow ne"></div>
        </div>
      </div>
    </div>
 </body>
</html>

CSS

@import url(http://fonts.googleapis.com/css?family=Dosis:200,400,500,600);

body {
    background: url(http://eskipaper.com/images/pixel-backgrounds-1.jpg);
    background-size: auto;
  background-repeat: no-repeat;
    font-family: Ranga, cursive;
}

h4 {
  margin-top: 7px;
}

h1 {
    margin-left: -7px;
  font-size: 1.05em;
    color: white;
}

#header {
    background: #2980b9;
    color: white;
    padding: 0 5px;
    display: inline-block;
    width: 100%;
    margin: 0;
    box-shadow: 0 2px 5px #555555;
}

#header .left {
    display: inline-block;
    width: auto;
    float: left;
    margin-top: 7px;
    margin-left: 7px;
}

#header .navbar {
    display: inline-block;
    width: 60%;
}

#header .right {
    display: inline-block;
    width: auto;
    text-align: right;
    float: right;
    margin-top: 2px;
    margin-right: 7px;
    vertical-align: bottom;
}

.bigger_icon {
    margin-top: 10px;
  font-size: 2em;
    color: white;
}

#map {
    height: 200px;
    width: 200px;
    border-radius: 5%;
    margin-top: 20px;
}

#container {
    background: rgba(66, 66, 66, 0.6);
    display: block;
    position: relative;
    width: 40%;
    margin: 24px auto;
    min-height: 300px;
    padding: 16px;
    border-radius: 4px;
}

#container .center-text {
    text-align: center;
}

h2 {
    color: white;
    font-family: Ranga, cursive;
    font-size: 2.5em;
    font-weight: bold;
    margin-top: -230px;
}

#caption {
    font-size: 17px;
    text-align: center;
    color: pink;
}

#labels {
    color: darkGrey;
    font-size: 1.5em;
}

.oneLine {
    color: darkGrey;
    font-size: 1.5em;
    text-align: center;
    display: inline;
    padding: 5px;
}

#high {
    text-align: center;
    color: orange;
}

#low {
    text-align: center;
    color: blue;
}

#currentConditions {
    text-align: center;
    color: black;
}

#weatherDesc {
    margin-top: -25px;
    color: white;
}

.windCompass {
    margin-left: 75%;
    margin-top: -20%;
}

.compass {
    display: block;
    width: 120px;
    height: 120px;
    border-radius: 100%;
    box-shadow: 0 0 10px rgba(0, 0, 0, 0.85);
    position: relative;
    font-family: 'Dosis';
    color: #555;
    text-shadow: 1px 1px 1px white;
}

.compass:before {
    font-weight: bold;
    position: absolute;
    text-align: center;
    width: 100%;
    content: "N";
    font-size: 14px;
    top: -2px;
}

.compass .direction {
    height: 100%;
    width: 100%;
    display: block;
    background: #f2f6f5;
    background: -moz-linear-gradient(top, #f2f6f5 30%, #cbd5d6 100%);
    background: -webkit-gradient(linear, left top, left bottom, color-stop(0%, #f2f6f5), color-stop(100%, #cbd5d6));
    background: -webkit-linear-gradient(top, #f2f6f5 0%, #cbd5d6 100%);
    background: o-linear-gradient(top, #f2f6f5 0%, #cbd5d6 100%);
    border-radius: 100%;
}

.compass .direction p {
    text-align: center;
    margin: 0;
    padding: 0;
    position: absolute;
    top: 50%;
    left: 0;
    width: 100%;
    height: 100%;
    line-height: 80px;
    display: block;
    margin-top: -35%;
    font-size: 28px;
    font-weight: bold;
}

.compass .direction p span {
    display: block;
    line-height: normal;
    margin-top: -10%;
    font-size: 17px;
    text-transform: uppercase;
    font-weight: normal;
  font-family: Ranga, cursive; 
}

.compass .arrow {
    width: 100%;
    height: 100%;
    display: block;
    position: absolute;
    top: 0;
}

.compass .arrow:after {
    content: "";
    width: 0;
    height: 0;
    border-left: 5px solid transparent;
    border-right: 5px solid transparent;
    border-bottom: 10px solid red;
    position: absolute;
    top: -6px;
    left: 50%;
    margin-left: -5px;
    z-index: 99;
}

.compass .arrow.nne {
    transform: rotate(22.5deg);
}

.compass .arrow.ne {
    transform: rotate(45deg);
}

.compass .arrow.ene {
    transform: rotate(67.5deg);
}

.compass .arrow.e {
    transform: rotate(90deg);
}

.compass .arrow.ese {
    transform: rotate(112.5deg);
}

.compass .arrow.se {
    transform: rotate(135deg);
}

.compass .arrow.sse {
    transform: rotate(157.5deg);
}

.compass .arrow.s {
    transform: rotate(180deg);
}

.compass .arrow.ssw {
    transform: rotate(202.5deg);
}

.compass .arrow.sw {
    transform: rotate(-135deg);
}

.compass .arrow.wsw {
    transform: rotate(-114.5deg);
}

.compass .arrow.w {
    transform: rotate(-90deg);
}

.compass .arrow.wnw {
    transform: rotate(-69.5deg);
}

.compass .arrow.nw {
    transform: rotate(-45deg);
}

.compass .arrow.nnw {
    transform: rotate(-24.5deg);
}

Ajax , , . , , . , , .

, .

, css , , . ( .

On Click does not update function output

More articles: