Need a space after [and without a space before or after =in the destination. $(($i+1)))will try to execute the output of the expression ((...)), and I'm sure that is not what you need. Also, what you are missing is $before the array name.
After fixing these errors, your while loop will:
#!/bin/bash
i=0
while [ "$i" -le "${#myarray[@]}" ]
do
echo "Welcome $i times"
i=$((i + 1))
done
i=$((i + 1)) can also be written as ((i++))- it's always better to enclose variables in double quotes inside
[ ... ] - shellcheck -
: