Zend Framework function that is not an action in the controller

Question

Is it a bad practice to create a function in a controller that is not an action?

Example

: Function createCookiein the lower controller

protected $translator;
protected $cookie;

public function __construct($translator, $cookie)
{
    $this->translator = $translator;
    $this->cookie = $cookie;
}

public function changeLanguageAction()
{
    $language = $this->params()->fromRoute('lang', 'en');
    $this->createCookie('xuage', $language, '/');
    $this->getResponse()->getHeaders()->addHeader($this->cookie);
    $this->redirect()->toRoute('home');
}

public function createCookie($name, $value, $path)
{
    $this->cookie->setName($name);
    $this->cookie->setValue($value);
    $this->cookie->setPath($path);
}

Answer 1

In my opinion, this can lead to the fact that your code will be more difficult to maintain, due to the fact that:

• You cannot share the createCookie function between different controllers, and you replicate your functions to different controllers.
• Even if you expand your controllers to the base, it can lead to over-distribution and make your code unreachable again.
• , " ".

:

• Zend 2
• Zend 1

Answer 2

CookieService createCookie . , , cookie.

protected $translator;
protected $cookieService;

public function __construct($translator, CookieService $cookie)
{
    $this->translator = $translator;
    $this->cookieService = $cookieService;
}

public function changeLanguageAction()
{
    $language = $this->params()->fromRoute('lang', 'en');
    $this->cookieService->createCookie('xuage', $language, '/');
    $this->redirect()->toRoute('home');
}

cookie . , CookieService:

$this->getResponse()->getHeaders()->addHeader($this->cookie);

Answer 3

Jannes Botis, ...

If you look at one of the last Matthew blog post (section Using zend-soap within a zend-mvc application), you will see that it uses a private function ( populateServer), which has only a reason in the context of both of the above actions.

I see what you used zend-framework3, so I would recommend using a stack

final class MyAction()
{
    private $next;

    public function __construct(callable $next = null)
    {
        $this->next = $next;
    }

    public function __invoke(ServerRequestInterface $request, ResponseInterface $response, callable $next = null) : ResponseInterface
    {
        // your business code
        if ($this->next) {
            $call = $this->next;
            $call($request, $response);
        }
        if ($next) {
            $next($request, $response);
        }
        return $response;
    }
}

Let us know how this happens if you go down this route :)