Spring Download, java.lang.IllegalStateException when calling ControllerLinkBuilder.linkTo from websocket

Question

I get the following error when calling ControllerLinkBuilder.linkTofrom websocket.

 java.lang.IllegalStateException: Could not find current request via RequestContextHolder
    at org.springframework.util.Assert.state(Assert.java:385)
    at org.springframework.hateoas.mvc.ControllerLinkBuilder.getCurrentRequest(ControllerLinkBuilder.java:234)
    at org.springframework.hateoas.mvc.ControllerLinkBuilder.getBuilder(ControllerLinkBuilder.java:186)
    at org.springframework.hateoas.mvc.ControllerLinkBuilderFactory.linkTo(ControllerLinkBuilderFactory.java:117)
    at org.springframework.hateoas.mvc.ControllerLinkBuilder.linkTo(ControllerLinkBuilder.java:135)
    at urlshortener2014.common.web.UrlShortenerController.createAndSaveIfValid(UrlShortenerController.java:94)
    at urlshortener2014.richcarmine.web.UrlShortenerControllerWithLogs.access$200(UrlShortenerControllerWithLogs.java:45)
    at urlshortener2014.richcarmine.web.UrlShortenerControllerWithLogs$CreateCallable.call(UrlShortenerControllerWithLogs.java:226)
    at urlshortener2014.richcarmine.massiveShortenerNaiveWS.ShortURLWSGenerator.onCall(ShortURLWSGenerator.java:41)
    at urlshortener2014.richcarmine.massiveShortenerNaiveWS.ShortURLWSGenerator.onCall(ShortURLWSGenerator.java:15)
    at urlshortener2014.richcarmine.massiveShortenerREST.RequestContextAwareCallable.call(RequestContextAwareCallable.java:26)
    at java.util.concurrent.FutureTask.run(FutureTask.java:266)
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
    at java.util.concurrent.FutureTask.run(FutureTask.java:266)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
    at java.lang.Thread.run(Thread.java:745)

The whole project is dedicated to URL shortening, as my first approach with spring web sockets I am trying to get it working by simply responding to a shortened URL from any URL.

My TextWebSocketHandler

public class MyHandler extends TextWebSocketHandler {

    AtomicLong messageOrder = new AtomicLong(0);
    ExecutorService threadPool = Executors.newCachedThreadPool();
    CompletionService<CSVContent> pool = new ExecutorCompletionService<>(threadPool);

    /* controller reference */
    @Autowired
    UrlShortenerControllerWithLogs controller;

    @Override
    protected void handleTextMessage(WebSocketSession session, TextMessage message) throws Exception {
        logger.info("WS: " + message.getPayload());
        long order = messageOrder.getAndIncrement();
        pool.submit(new ShortURLWSGenerator(order,message.getPayload(),"","","",session.getRemoteAddress(),controller));
        CSVContent content = pool.take().get();
        session.sendMessage(new TextMessage("Echo Test: " + content.getShortURL().getUri()));
    }
}

Here ShortURLWSGenerator

public class ShortURLWSGenerator extends RequestContextAwareCallable<CSVContent>{
    ...
    @Override
    public CSVContent onCall() {

        ShortURL shortURL = null;
        try {
            shortURL = controller. new CreateCallable(url,sponsor,brand,owner,address.toString()).call();
        } catch (Exception e) {
            e.printStackTrace();
        }

        CSVContent content = new CSVContent();
        content.setOrder(order);
        content.setShortURL(shortURL);

        return content;
    }
}

It uses RequestContextAwareCallable , which solved the same problem when implementing the same function as the REST service, in any case, I still get the same error even with a simple Callable.

Here is CreateCallable that just wraps the main function

public class CreateCallable implements Callable<ShortURL>{
    ...
    @Override
    public ShortURL call() throws Exception {
        /* explodes while creating the new short url */
        return createAndSaveIfValid(url,sponsor,brand,owner,ip);
    }
}

Finally, here createAndSaveIfValid, which callsControllerLinkBuilder.linkTo

protected ShortURL createAndSaveIfValid(String url, String sponsor,
        String brand, String owner, String ip) {
    UrlValidator urlValidator = new UrlValidator(new String[] { "http",
            "https" });
    if (urlValidator.isValid(url)) {
        String id = Hashing.murmur3_32()
                .hashString(url, StandardCharsets.UTF_8).toString();
        ShortURL su = new ShortURL(id, url,
                linkTo(
                        methodOn(UrlShortenerController.class).redirectTo(
                                id, null)).toUri(), sponsor, new Date(
                        System.currentTimeMillis()), owner,
                HttpStatus.TEMPORARY_REDIRECT.value(), true, ip, null);
        return shortURLRepository.save(su);
    } else {
        return null;
    }
}

The full project can be found here on github

Answer 1

linkTo HTTP-, HTTP- , WebSocket. .

• , . createAndSaveIfValidExtended createAndSaveIfValid. , linkTo(methodOn(UrlShortenerController.class).redirectTo(id, null)).toUri() createLink(id)

• String createLink(String id). URL-, , application.properties (. ), , /l ìd.

• CreateCallable createAndSaveIfValidExtended createAndSaveIfValid

Answer 2

, ResourceAssemblerSupport , :

@Before
public void setup() {
    HttpServletRequest mockRequest = new MockHttpServletRequest();
    ServletRequestAttributes servletRequestAttributes = new ServletRequestAttributes(mockRequest);
    RequestContextHolder.setRequestAttributes(servletRequestAttributes);
}

@After
public void teardown() {
    RequestContextHolder.resetRequestAttributes();
}

Answer 3

Here's an even simpler version of Robert Ben's code that we ended up using in our Spock tests ...

    HttpServletRequest httpServletRequestMock = new MockHttpServletRequest()
    ServletRequestAttributes servletRequestAttributes = new ServletRequestAttributes(httpServletRequestMock)
    RequestContextHolder.setRequestAttributes(servletRequestAttributes)