How to write long IF more beautifully?

Question

I have a long IF:

if(rand(1, 100) == 22 && $smth < time() && $smths > 5 && $sxsxsx > 250 && !$_SESSION['false']) { echo "wow, big if just happened!"; } 

How to write it more "prettier"?

Answer 1

According to my answer to the related

• Multiple IF condition statements

this needs to be reorganized using the Decompose Conditional , which means you have to make separate tests separate functions. And you have to get rid of magic numbers and meaningless variable names. I would give you an example of how to do this for your code, but the code is incomprehensible.

Answer 2

I prefer to split before boolean operators.

 if(rand(1, 100) == 22 && $smth < time() && $smths > 5 && $sxsxsx > 250 && !$_SESSION['false'] ) 

Answer 3

I like to name my conditions and group them so that they understand what their purpose is.

 $is22 = rand(1, 100) == 22; $someTime = $smth < time() && $smths > 5; $meetsSx = $sxsxsx > 250; $inSession = !$_SESSION['false']; if ($is22 && $someTime && $meetsSx && $inSession) { // do something } 

Answer 4

 $isSomethingValid = rand(1, 100) == 22 && $smth < time() && $smths > 5 && $sxsxsx > 250 && !$_SESSION['false']; if ($isSometingValid) { // do something } 

Answer 5

Always retreat to the attached statement for one additional than the body of the block. You should write a function like this:

 function (reallylongparam, reallylongparam, reallylongparam, reallylongparam, reallylongparam) { doStuff() } 

therefore, you should write your if statement as follows:

 if(rand(1, 100) == 22 && $smth < time() && $smths > 5 && $sxsxsx > 250 && !$_SESSION['false']) { doStuff(); } 

Answer 6

probably,

 if( rand(1, 100) == 22 && $smth < time() && $smths > 5 && $sxsxsx > 250 && !$_SESSION['false'] ) { echo "wow, big if just happened!"; } 

amuses

Answer 7

Creating your code for reading is a very important aspect when it comes to supporting your code - someone may need this support.

Check out the coding styles (find more information if you need to).

Personally, I would format this snippet like this:

 if ( rand(1, 100) == 22 && $smth < time() && $smths > 5 && $sxsxsx > 250 && !$_SESSION['false'] ) { echo "wow, big if just happened!"; } 

Answer 8

Just encapsulate the logic in a separate function

Answer 9

You can also simplify reading variable names.