A href = "javascript: doSomething" means that you do not have a URL to return if the user has not enabled js.
Therefore setting href = "something.html" and onclick = "return doSomething ()" is usually considered better, because if js is disabled, you can go to a new page, but if js is turned on, you can return false to prevent link navigation and displaying something on one page without refreshing the page.
Even better, don't add inline onclick, just add js handlers when the page loads. This is an unobtrusive way.
source share