The problem with this feature. The code does not execute.

Question

The function should update the values ​​in the database.

Here is the code:

//Functions //Function to Update users networth function update_net($name) { //Get worth & balance at the time $sql_to_get_worth_balance = "SELECT * FROM user WHERE username = '$name'"; $sql_query = mysql_query($sql_to_get_worth_balance); while ($rows = mysql_fetch_assoc($sql_query)) { $worth = $rows['worth']; $balance_ = $rows['cash_balance']; } //Get net_worth now $new_net_worth = $worth + $balance; //Update net_worth $sql_for_new_worth = "UPDATE user SET net_worth = '$new_net_worth'"; $sql_worth_query = mysql_query($sql_worth); } 

It is used here:

 //Get username $username = $_SESSION['username']; if (isset($username)) { //Update networth $update_worth = update_net($username); 

Answer 1

You probably need a WHERE clause at the end of this query: -

 $sql_for_new_worth = "UPDATE user SET net_worth = '$new_net_worth'"; 

eg.

 $sql_for_new_worth = "UPDATE user SET net_worth = '$new_net_worth' WHERE username = '$name'; 

Answer 2

• You forget where name = $ name in the update request (which will update the whole table!)
• I hope your $ name will never be able to store user input because your sql is vulgar for injection.

Answer 3

May be:

 //Update net_worth $sql_for_new_worth = "UPDATE user SET net_worth = '$new_net_worth'"; $sql_worth_query = mysql_query($sql_worth); 

Must read:

 //Update net_worth $sql_for_new_worth = "UPDATE user SET net_worth = '$new_net_worth'"; $sql_worth_query = mysql_query($sql_for_new_worth); 

Answer 4

Maybe you should make a transaction?