Python - Check network card

Question

I am looking for some help on logic, the code is not very Pythonic. I am still participating. We constantly display drive Z: in different locations. Here is what I'm trying to accomplish

1: check the old card on Z: say \ 192.168.1.100 \ old
2: Map the new location to Z: say \ 192.168.1.200 \ new
3: Verify that a new Z: mapping exists and is still connected. 4: If it is disconnected or not connected, reconnect it and write it down

90% of the code works, if I run it as it is, it cancels the old disk and maps the new disk, but the name of the old disk remains unchanged, even if it is mapped to a new location, and I can view it. Another problem is only that I want to run checkOldDrive once and just run checkDrive . Any advice is appreciated.

#!/usr/bin/python import pywintypes import win32com.client import os.path import sys import string import fileinput import time import win32net ################################################################## # Check for old Z: map and remove it # Map the new instance of Z: # Check if the Z: drive exists # if the drive exists report to status.log we are working # if the drive DOES NOT exist map it and report errors to the log ################################################################### def checkDrive(): if os.path.exists('z:'): saveout = sys.stdout fsock = open('status.log', 'a') sys.stdout = fsock print os.getenv("COMPUTERNAME"), " - ", time.ctime(), " - Connected" sys.stdout = saveout fsock.close() else: ivvinetwork = win32com.client.Dispatch('Wscript.Network') network_drives = ivvinetwork.EnumNetworkDrives() for mapped_drive in [network_drives.Item(i) for i in range(0, network_drives.Count() -1 , 2) if network_drives.Item(i)]: ivvinetwork.RemoveNetworkDrive(mapped_drive, True, True) drive_mapping = [ ('z:', '\\\\192.168.1.100\\newmap', 'someuser', 'somepass')] for drive_letter, network_path, user_name, user_pass in drive_mapping: try: ivvinetwork.MapNetworkDrive(drive_letter, network_path, True, user_name, user_pass) saveout = sys.stdout fsock = open('status.log', 'a') sys.stdout = fsock print os.getenv("COMPUTERNAME"), " - ", time.ctime(), " - ", drive_mapping, "Drive Has Been Mapped" sys.stdout = saveout fsock.close() except Exception, err: saveout = sys.stdout fsock = open('status.log', 'a') sys.stdout = fsock print os.getenv("COMPUTERNAME"), " - ", time.ctime(), " - ", err sys.stdout = saveout fsock.close() def checkOldDrive(): if os.path.exists('z:'): ivvinetwork = win32com.client.Dispatch('Wscript.Network') network_drives = ivvinetwork.EnumNetworkDrives() for mapped_drive in [network_drives.Item(i) for i in range(0, network_drives.Count() -1 , 2) if network_drives.Item(i)]: ivvinetwork.RemoveNetworkDrive(mapped_drive, True, True) checkOldDrive() checkDrive() 

Answer 1

I have compiled a script based on the one you have outlined, which I assume is fulfilling what you described.

I tried to make it so that Pythonic also followed good programming principles.

In particular, I did the following:

• modulate most of the functionality in a reusable function
• avoid repeating as much as possible. I did not take into account the hard-coded drive "Z:". I leave this for you as an exercise (as you see fit).
• defined the definition of registration in one place (so that the format, etc. is consistent and not repeated). The logging module has simplified the work.
• moved all code from the top-level area (except for some global constants). This allows you to run the script directly or be imported by another script as a module.
• Added some documentation lines to help document what each function does.
• Keeps each function short brief, so it can be easily read on one screen and in an isolated context.

Of course, there is still something to improve, but I tested this script and it is functional. He should provide good lessons as well as help you complete your task. Enjoy it.

 #!/usr/bin/env python import os import time import win32com.client import logging old_mappings = [ r'\\192.168.1.100\old', ] new_mapping = r'\\192.168.1.200\new' LOG_FILENAME = 'status.log' def main(): """ Check to see if Z: is mapped to the old server; if so remove it and map the Z: to the new server. Then, repeatedly monitor the Z: mapping. If the Z: drive exists, report to status.log that we are working. Otherwise, re-map it and report errors to the log. """ setupLogging() replaceMapping() monitorMapping() def replaceMapping(): if removeMapping(): createNewMapping() def setupLogging(): format = os.environ['COMPUTERNAME'] + " - %(asctime)s - %(message)s" logging.basicConfig(filename=LOG_FILENAME, level=logging.DEBUG, format=format) def getCredentials(): """ Return one of three things: - an empty tuple - a tuple containing just a username (if a password is not required) - a tuple containing username and password """ return ('someuser', 'somepass') def createNewMapping(): network = win32com.client.Dispatch('WScript.Network') params = ( 'Z:', # drive letter new_mapping, # UNC path True, # update profile ) params += getCredentials() try: network.MapNetworkDrive(*params) msg = '{params} - Drive has been mapped' logging.getLogger().info(msg.format(**vars())) except Exception as e: msg = 'error mapping {params}' logging.getLogger().exception(msg.format(**vars())) def monitorMapping(): while True: # only check once a minute time.sleep(60) checkMapping() def checkMapping(): if getDriveMappings()['Z:'] == new_mapping: msg = 'Drive is still mapped' logging.getLogger().info(msg.format(**vars())) else: replaceMapping() # From Python 2.6.4 docs from itertools import izip_longest def grouper(n, iterable, fillvalue=None): "grouper(3, 'ABCDEFG', 'x') --> ABC DEF Gxx" args = [iter(iterable)] * n return izip_longest(fillvalue=fillvalue, *args) def getDriveMappings(): """ Return a dictionary of drive letter to UNC paths as mapped on the system. """ network = win32com.client.Dispatch('WScript.Network') # http://msdn.microsoft.com/en-us/library/t9zt39at%28VS.85%29.aspx drives = network.EnumNetworkDrives() # EnumNetworkDrives returns an even-length array of drive/unc pairs. # Use grouper to convert this to a dictionary. result = dict(grouper(2, drives)) # Potentially several UNC paths will be connected but not assigned # to any drive letter. Since only the last will be in the # dictionary, remove it. if '' in result: del result[''] return result def getUNCForDrive(drive): """ Get the UNC path for a mapped drive. Throws a KeyError if no mapping exists. """ return getDriveMappings()[drive.upper()] def removeMapping(): """ Remove the old drive mapping. If it is removed, or was not present, return True. Otherwise, return False or None. """ mapped_drives = getDriveMappings() drive_letter = 'Z:' if not drive_letter in mapped_drives: return True if mapped_drives[drive_letter] in old_mappings: network = win32com.client.Dispatch('WScript.Network') force = True update_profile = True network.RemoveNetworkDrive(drive_letter, force, update_profile) return True # return None if __name__ == '__main__': main()