Spring JSR-303/349 Boot Configuration

Question

In my Spring Boot 1.5.1 application, I am trying to configure JSR-303 / JSR-349 validation support.

I added the following annotations @NotNull @Size(min = 1) to my method:

 @Service @Transactional public class DecisionDaoImpl extends BaseDao implements DecisionDao { @Override public Decision create(@NotNull @Size(min = 1) String name, String description, String url, String imageUrl, Decision parentDecision, Tenant tenant, User user) { ... } } 

I am trying to call this method from my test, but it does not fail in the validation constraints.

This is my test and configs:

 @SpringBootTest(classes = { TestConfig.class, Neo4jTestConfig.class }) @RunWith(SpringRunner.class) @Transactional public class TenantTest { @Test public void testCreateDecision() { User user1 = userService.createUser("test1", "test1", " [e-mail] ", null, null); Tenant tenant1 = tenantDao.create("Tenant 1", "Tenant 1 description", false, user1); // the following line should fail on the validation constraint because name parameter is null but it doesn't final Decision rootDecision = decisionDao.create(null, "Root decision 1 description", null, tenant1, user1); ... @Configuration @ComponentScan("com.example") @SpringBootApplication(exclude={Neo4jDataAutoConfiguration.class}) public class TestConfig { } 

What am I doing wrong and how to configure JSR-303 there?

UPDATED

I added

 public Decision create(@Valid @NotNull @Size(min = 1) String name, String description, Decision parentDecision, Tenant tenant, User author) { 

but it still does not work

I added @Validated to my DecisionDaoImpl , but now it fails with the following exception:

 Caused by: org.springframework.beans.factory.BeanCurrentlyInCreationException: Error creating bean with name 'decisionDaoImpl': Bean with name 'decisionDaoImpl' has been injected into other beans [criterionGroupDaoImpl,characteristicGroupDaoImpl,tenantDaoImpl] in its raw version as part of a circular reference, but has eventually been wrapped. This means that said other beans do not use the final version of the bean. This is often the result of over-eager type matching - consider using 'getBeanNamesOfType' with the 'allowEagerInit' flag turned off, for example. at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:585) at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:483) at org.springframework.beans.factory.support.AbstractBeanFactory$1.getObject(AbstractBeanFactory.java:306) at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:230) at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:302) at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:202) at org.springframework.beans.factory.config.DependencyDescriptor.resolveCandidate(DependencyDescriptor.java:208) at org.springframework.beans.factory.support.DefaultListableBeanFactory.doResolveDependency(DefaultListableBeanFactory.java:1138) at org.springframework.beans.factory.support.DefaultListableBeanFactory.resolveDependency(DefaultListableBeanFactory.java:1066) at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredFieldElement.inject(AutowiredAnnotationBeanPostProcessor.java:585) ... 43 common frames omitted 

I also added @Lazy annotation in places where I autowiring my DecisionDao , but right now my test failed with the following exception:

 javax.validation.ConstraintDeclarationException: HV000151: A method overriding another method must not alter the parameter constraint configuration, but method public com.example.domain.model.entity.decision.Decision com.example.domain.dao.decision.DecisionDaoImpl.create(java.lang.String,java.lang.String,java.lang.String,java.lang.String,java.lang.Long,java.lang.Long,com.example.domain.model.entity.user.User) changes the configuration of public abstract com.example.domain.model.entity.decision.Decision com.example.domain.dao.decision.DecisionDao.create(java.lang.String,java.lang.String,java.lang.String,java.lang.String,java.lang.Long,java.lang.Long,com.example.domain.model.entity.user.User). at org.hibernate.validator.internal.metadata.aggregated.rule.OverridingMethodMustNotAlterParameterConstraints.apply(OverridingMethodMustNotAlterParameterConstraints.java:24) at org.hibernate.validator.internal.metadata.aggregated.ExecutableMetaData$Builder.assertCorrectnessOfConfiguration(ExecutableMetaData.java:456) 

Answer 1

Move your interface check as follows:

 import javax.validation.Valid; import javax.validation.constraints.NotNull; import javax.validation.constraints.Size; public interface DecisionDao { Decision create(@Valid @NotNull @Size(min = 1) String name, String description, String url, String imageUrl); } 

Annotate DecisionDaoImpl using @Validated as follows:

 import org.springframework.stereotype.Service; import org.springframework.validation.annotation.Validated; @Service @Validated public class DecisionDaoImpl extends BaseDao implements DecisionDao { @Override public Decision create(String name, String description, String url, String imageUrl) { System.out.println(name); return new Decision(); } } 

Modify the test case to test javax.validation.ConstraintViolationException using assertj or ExpectedException as follows:

 import static org.assertj.core.api.Assertions.assertThatExceptionOfType; import javax.validation.ConstraintViolationException; import org.junit.Test; import org.junit.runner.RunWith; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.context.annotation.Bean; import org.springframework.context.annotation.Configuration; import org.springframework.test.context.ContextConfiguration; import org.springframework.test.context.junit4.SpringRunner; import org.springframework.validation.beanvalidation.MethodValidationPostProcessor; @ContextConfiguration(classes = { TenantTest.Config.class }) @RunWith(SpringRunner.class) public class TenantTest { @Autowired private DecisionDao decisionDao; @Rule public ExpectedException expectedException = ExpectedException.none(); @Test public void testCreateDecisionUsingAssertj() { assertThatExceptionOfType(ConstraintViolationException.class) .isThrownBy( () -> decisionDao.create(null, "Root decision 1 description", null, null)); } @Test public void testCreateDecision() { expectedException.expect(ConstraintViolationException.class); decisionDao.create(null, "Root decision 1 description", null, null); } @Configuration public static class Config { @Bean public MethodValidationPostProcessor methodValidationPostProcessor() { return new MethodValidationPostProcessor(); } @Bean public DecisionDao decisionDao() { return new DecisionDaoImpl(); } } } 

Make sure you have a hibernate-validator in your class path along with @StanislavL's answer:

 <dependency> <groupId>org.hibernate</groupId> <artifactId>hibernate-validator</artifactId> </dependency> 

And an optional dependency for org.assertj.core.api.Assertions.assertThatExceptionOfType , like:

 <dependency> <groupId>org.assertj</groupId> <artifactId>assertj-core</artifactId> <version>3.3.0</version> <scope>test</scope> </dependency> 

An example is arpitaggarwal / jsr-303

Answer 2

You need @Valid annotation

Marks a property, method, or method of return type for cascading validation. Constraints defined for an object and its properties are checked when the property, method, or method of the return type.

Answer 3

Constraint annotations are for use with JavaBeans. See http://beanvalidation.org/1.0/spec/#constraintsdefinitionimplementation-constraintdefinition

You have a constraint annotation @NotNull , @Size , etc., used in the DAO. You must create a Java Bean, for example. The “Person” that wraps these attributes (name, description, etc.), then passes the “Person” as a parameter to the controller method. If you need to use a DAO instead of a controller, you will need to perform a test to verify it. You can be on your own regarding AOP, etc. If nothing has changed since publication: http://forum.spring.io/forum/spring-projects/container/82643-annotation-driven-jsr-303 -validation-on-service-and-dao-tier

Refresh . Well, it looks like this (JSR-349 level confirmation) is now supported, see http://blog.codeleak.pl/2012/03/how-to-method-level-validation-in.html for an example similar to Arpit answer. Updated question title to reflect this latest JSR.